2.8.0f1-keys with national characters from googl

Start
Prev
1
Next
End

1

Killersan
Topic Author
Offline
New Member

More

6 years 6 months ago #2486 by Killersan

2.8.0f1-keys with national characters from googl was created by Killersan

Hello everyone. From the start we had translation in excel on google drive where keys had some national marks like ó,ł and such coded I think in Win1250 and all was working fine till version 2.8.0f1 where translation of keys with such national letters returns empty string.

Please Log in or Create an account to join the conversation.

Frank
Offline
Administrator

More

6 years 6 months ago #2489 by Frank

Replied by Frank on topic 2.8.0f1-keys with national characters from googl

Hi,
To avoid including invalid characters in the term name (e.g. new lines, controls and invisible chars), the term's name removes any character that is not a letter, digit
or some punctuation sign.

However, I agree that is very restricted, so I'm changing the function to allow even extended characters (e.g. Chinese and other UNICODE characters).

You can fix it by replacing the function RemoveNonASCII function in assets\i2\localization\scripts\localizationmanager.cs line 468

        public static string RemoveNonASCII( string text, bool allowCategory=false )
        {
            if (string.IsNullOrEmpty(text))
                return text;

            return new string(text.Select(c => (char.IsControl(c)|| (c=='\\' && !allowCategory)) ? ' ' : c).ToArray());
        }

This has been included in 2.8.0f2 which I will release on Monday to the AssetStore.

Hope that helps,
Frank

Are you