Welcome, Guest
Username: Password: Remember me

TOPIC: Bug: UpgradeManager and Scripting Define Symbols

Bug: UpgradeManager and Scripting Define Symbols 4 years 7 months ago #166

  • Jos
  • Jos's Avatar
  • Offline
  • Junior Member
  • Posts: 32
  • Karma: 0
The UpgradeManager seems to keep adding the NGUI define to my Scripting Define Symbol list without me asking it to. I never select that menu option from Tools/Localization. Each time i update the i2 code i have to go and comment out the call to the EnablePlugins() method, to prevent it from adding that define.

I have not been able to track down why that is happening - we are not using NGUI in our project.

Just a FYI.

Jos
The administrator has disabled public write access.

Bug: UpgradeManager and Scripting Define Symbols 4 years 7 months ago #173

  • Jos
  • Jos's Avatar
  • Offline
  • Junior Member
  • Posts: 32
  • Karma: 0
Just installed v.2.1.0.f2 and still get this issue with NGUI being added to my "Scripting Define Symbol" list without me asking it to add it.
The administrator has disabled public write access.

Bug: UpgradeManager and Scripting Define Symbols 4 years 7 months ago #174

  • Jos
  • Jos's Avatar
  • Offline
  • Junior Member
  • Posts: 32
  • Karma: 0
Maybe because i've already got a bunch of items in the list?
The administrator has disabled public write access.

Bug: UpgradeManager and Scripting Define Symbols 4 years 6 months ago #177

  • Frank
  • Frank's Avatar
  • Offline
  • Administrator
  • Posts: 1178
  • Thank you received: 253
  • Karma: 78
Hi,

When deciding whatever the plugin should add "NGUI" to the Define Symbol list, the EnablePlugins uses reflection to see if there is a class named UIPanel in the project.

That class is normally part of the NGUI, but could it be the case that you have a class with that name in your code or a java file with that name?

Thanks,
Frank
Are you :-) Give I2L 5 stars!
Are you :-( Please lets us know how to improve it!
To get the betas as soon as they are ready, check this out
The administrator has disabled public write access.

Bug: UpgradeManager and Scripting Define Symbols 4 years 6 months ago #180

  • Jos
  • Jos's Avatar
  • Offline
  • Junior Member
  • Posts: 32
  • Karma: 0
Yep, we do have a UIPanel class/component. While I appreciate that you want it to work as seamlessly as possible for your other users, especially those who have NGUI installed, this is sub-optimal for any other user. Perhaps some kind of explicit "do not use X" option, so, even if i get it turned on auto-magically, there is a way to also manually force it to off/disabled? This would still allow for your main use-case (easy/auto setup for NGUI users), but also for folks who have unintentionally been included to turn it off...

Thanks!
J
The administrator has disabled public write access.

Bug: UpgradeManager and Scripting Define Symbols 4 years 6 months ago #181

  • Frank
  • Frank's Avatar
  • Offline
  • Administrator
  • Posts: 1178
  • Thank you received: 253
  • Karma: 78
Instead of looking for the UIPanel class, I will make it look for NGUIHelp. Its very unlikely that class name gets used by other users :-)
Nonetheless, in the case it does, I will add a description about what method to disable in the source in order to stop the auto detection of the plugin.

Thanks,
Frank
Are you :-) Give I2L 5 stars!
Are you :-( Please lets us know how to improve it!
To get the betas as soon as they are ready, check this out
The administrator has disabled public write access.
The following user(s) said Thank You: Jos
Time to create page: 0.091 seconds
Template by JoomlaShine