Empty language present in list after Google import

More
7 years 11 months ago #1421 by joaquine
After the latest update, I'm getting an "empty" language in the list. See screenshot for reference. This in turn has the unwanted side-effect of making the CurrentLanguage null after startup, since the "saved language" is the empty string, and it matches one of the langauges in the list (with name empty string).

1) How do we make it not import an empty language?
2) Shouldn't it be an error case to have an empty language, even if manually created?
Attachments:

Please Log in or Create an account to join the conversation.

More
7 years 11 months ago #1423 by Frank
Hi,

Thanks for reporting this issue, As soon as I get back I will add a condition to discard empty languages.
Out of curiosity, how did you end up with the empty language? Does your spreadsheet have empty columns? Or are there texts in cells outside of the Language's columns?
Do did you just "Add" without selecting any text?

I will try reproducing this issue and send you a fix.

Thanks,
Frank

Are you :-) Give I2L 5 stars!
Are you :-( Please lets us know how to improve it!
To get the betas as soon as they are ready, check this out

Please Log in or Create an account to join the conversation.

More
7 years 11 months ago #1424 by joaquine
Thanks for the quick reply.
I'm not sure how I got into this state. I checked and the google sheet does not have an extra column, and as far as I can tell, no text outside the language columns. But I can still 100% reproduce it right now, even after manually deleting the empty language, after doing a replace-import the empty entry is there again.

Please Log in or Create an account to join the conversation.

More
7 years 11 months ago #1434 by Frank
Hi,
I modified the plugin to not allow include Empty languages.

- the "Add" button will not longer be active when there is no language name.
- Importing Google Spreadsheet and CSV will skip columns without a LanguageName

I uploaded the new version (2.6.6 a1) to the beta folder.

Hope that helps,
Frank

Are you :-) Give I2L 5 stars!
Are you :-( Please lets us know how to improve it!
To get the betas as soon as they are ready, check this out

Please Log in or Create an account to join the conversation.

Time to create page: 0.225 seconds
Template by JoomlaShine