Language matching is case-sensitive

Start
Prev
1
Next
End

1

studenman
Topic Author
Offline
Senior Member

More

6 years 8 months ago #2958 by studenman

Language matching is case-sensitive was created by studenman

I love how flexible I2L is when setting the languages, it's able to find an effective matching language without regard to word order. However, I'm using it with Steam and they refer to languages with lower-case strings like "english."

In LanguageSource.GetLanguageIndex, it calls GetCommonWordInLanguageNames, but this method is case-sensitive.

Slightly funny is that the comment above this code reads:
// Then allow matching "English (Canada)" to "english"
but I don't think it would actually work with lower-case "english".

My solution is to modify these lines in GetCommonWordInLanguageNames:

	string[] Words1 = Language1.ToLower().Split(separators);
	string[] Words2 = Language2.ToLower().Split(separators);

Follow Tiny Bubbles Development:
Twitter | Facebook | Web

Please Log in or Create an account to join the conversation.

Frank
Offline
Administrator

More

6 years 8 months ago #2959 by Frank

Replied by Frank on topic Language matching is case-sensitive

Thanks for looking into this!
You are absolutely right, AreSameLanguages is correctly using the IgnoreCase comparison, but GetCommonWordInLanguaNames is not.
I will correct this in the next beta.

Thanks for reporting it!!!
Frank

Are you