Need better fallback logic on missing translation

I like that idea.
The current implementation fallback to the base language, and if not found, then fallback to the first language in the list.

e.g. "es-MX" fallback to "es" which fallback to "en" if not found.

What I think maybe wrong, is that if "es" is not found, then it should fallback to another 'es-XX' language.
The code was design with the idea that you will always have a base language ('es', 'en', etc) and only create variants as needed ('es-Mx', 'en-UK'), and only for those terms that change, and allow the fallback to deal with the terms that are similar between variants.

I will start by adding the check, of falling back to the base language or one other 'es-XX' variant if the base is not found, and only if there is no other variant to fallback to, then go to the first language in the list.

Hope that helps,
Frank

You are correct. That's a bug for sure.

The fallback process was supposed to use the same as the GetLanguageIndex that allows discarding the language region.
I will correct that.

Thanks for reporting this!
Frank

BTW, I just uploaded to the beta folder v2.8.5a1 with a fix for this.

In the case you show, if you have a term with the following translations:
en-US:
en-GB: Translation1
es-ES:
es-MX Translation2
es-AR: Translation3
es-CO:
ja
zh-CN
zh-TW: Translation4

the resulting translation using fallbacks are:
en-US: Translation1
en-GB: Translation1
es-ES: Translation2
es-MX Translation2
es-AR: Translation3
es-CO: Translation2
ja: Translation1
zh-CN: Translation4
zh-TW: Translation4

Hope that helps,
Frank